Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improvement: Small adjustment to Code of Conduct sheet #254

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

eylulnc
Copy link
Contributor

@eylulnc eylulnc commented Dec 22, 2024

Problem Description

Changed the Code-of-Conduct bottom sheet from a half-screen modal to a full-screen display. The partial expansion previously blocked scrollable content, so adopting a full‐screen approach ensures all information is accessible in one click.

Note: This is a relatively small PR aimed to aligning the behavior with iOS and improving usability.

Changes

• Updated the Code-of-Conduct bottom sheet to always open as a full-screen modal on Android.
• Added slight padding for improved layout consistency, particularly for first-time acceptance of the Code of Conduct.

Steps for testing

  1. Open the Code of Conduct bottom sheet on both Android and iOS.
    • Confirm that the modal now matches iOS behavior, opening as a full-screen modal.
  2. Test first-time acceptance:
    • Verify that there is a small but noticeable gap (padding) between the text and header menu for better visual alignment.

Screenshots

Screenshot 2024-12-22 at 22 25 54 Screenshot 2024-12-22 at 22 25 41

@eylulnc eylulnc self-assigned this Dec 22, 2024
@eylulnc eylulnc added the ready for review This PR can be reviewed label Dec 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready for review This PR can be reviewed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant